docs(configure-mayastor): updated note to bypath or byid #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AJ_Datacore <[email protected]>
Signed-off-by: AJ_Datacore <[email protected]>
tiagolobocastro
approved these changes
Oct 30, 2023
blaisedias
approved these changes
Nov 1, 2023
tiagolobocastro
approved these changes
Nov 1, 2023
quickstart/configure-mayastor.md
Outdated
|
|
||
| Usage of the device name (for example, /dev/sdx) is not advised, as it may change if the node reboots, which might cause data corruption. | ||
| {% endhint %} | ||
|
|
||
| | Type | Format | Example | | ||
| | :--- | :--- | :--- | | ||
| | Disk(non PCI) with disk-by-guid reference <i><b>(Best Practice)</b></i> | Device File | aio:////dev/disk/by-uuid/<uuid> OR uring:////dev/disk/by-uuid/<uuid> | | ||
| | Disk(non PCI) with disk-by-guid reference <i><b>(Best Practice)</b></i> | Device File | aio:////dev/disk/by-id/<id> OR uring:////dev/disk/by-id/<id> | |
There was a problem hiding this comment.
sorry one more nit, there's an extra slash here
Suggested change
| | Disk(non PCI) with disk-by-guid reference <i><b>(Best Practice)</b></i> | Device File | aio:////dev/disk/by-id/<id> OR uring:////dev/disk/by-id/<id> | | |
| | Disk(non PCI) with disk-by-guid reference <i><b>(Best Practice)</b></i> | Device File | aio:///dev/disk/by-id/<id> OR uring:///dev/disk/by-id/<id> | |
Signed-off-by: AJ_Datacore <[email protected]>
|
cherry-picked |
tiagolobocastro
pushed a commit
that referenced
this pull request
Nov 28, 2023
* docs(configure-mayastor): updated note to by-path or by-id Signed-off-by: AJ_Datacore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to this issue: openebs/mayastor#1530
Hi @tiagolobocastro Could you please confirm if this change is relevant? If now, can you suggest the right place to add this note?