Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(fossa): update minikube version #194

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sinhaashish
Copy link
Member

Pull Request template

Please, go through these steps before you submit a PR. ## Remove this line

Why is this PR required? What issue does it fix?:
update minikube version to run ci tests

What this PR does?:

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered and commands you used for testing with logs:

Any additional information for your reviewer?:
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

PR title/commit message must follow convention: <type>(<scope>): <subject>.

Most common types are:
* `feat`      - for new features, not a new feature for build script
* `fix`       - for bug fixes or improvements, not a fix for build script
* `chore`     - changes not related to production code
* `docs`      - changes related to documentation
* `style`     - formatting, missing semi colons, linting fix etc; no significant production code changes
* `test`      - adding missing tests, refactoring tests; no production code change
* `refactor`  - refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@sinhaashish sinhaashish force-pushed the bump-minikube-version branch 2 times, most recently from e1f0bd3 to 0bda9d8 Compare October 31, 2024 11:11
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shellcheck

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

kubectl logs --tail=${LC} $MAPIPOD -n openebs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

if [ -z $VELERO_RELEASE ] || [ -z $OPENEBS_RELEASE ]; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

if [ -z $VELERO_RELEASE ] || [ -z $OPENEBS_RELEASE ]; then

@tiagolobocastro
Copy link

Test is failing because it's waiting for CStorPoolCluster
That bit should be removed, including any cstor code.

@sinhaashish
Copy link
Member Author

Test is failing because it's waiting for CStorPoolCluster That bit should be removed, including any cstor code.

The installation itself is installing cstor https://raw.githubusercontent.com/openebs/openebs/v3.10.0/k8s/openebs-operator.yaml and there is a lot of cstor stuff. Since cstor is deprecated, I wonder if continuing this repo makes sense.

@sinhaashish sinhaashish force-pushed the bump-minikube-version branch 13 times, most recently from 3632b85 to 2868876 Compare November 12, 2024 09:34

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

replicas=$(kubectl get deployment -n ${NS} ${DEPLOY} -o json | jq ".status.readyReplicas")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

replicas=$(kubectl get deployment -n ${NS} ${DEPLOY} -o json | jq ".status.readyReplicas")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

if [ ${DEPLOY} != "maya-apiserver" ] && [ ${DEPLOY} != "openebs-provisioner" ]; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

if [ ${DEPLOY} != "maya-apiserver" ] && [ ${DEPLOY} != "openebs-provisioner" ]; then

@sinhaashish sinhaashish force-pushed the bump-minikube-version branch 2 times, most recently from b477fc8 to 73abf38 Compare November 12, 2024 10:00
@@ -37,7 +38,7 @@ function waitForDeployment() {
fi

for i in $(seq 1 50) ; do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
i appears unused. Verify use (or export if used externally). SC2034

@sinhaashish sinhaashish force-pushed the bump-minikube-version branch 16 times, most recently from 773f2e1 to 7a60191 Compare November 13, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants