-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(fossa): update minikube version #194
base: develop
Are you sure you want to change the base?
Conversation
e1f0bd3
to
0bda9d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
velero-plugin/script/install-openebs.sh
Line 65 in 0bda9d8
kubectl logs --tail=${LC} $MAPIPOD -n openebs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
velero-plugin/script/install-openebs.sh
Line 17 in 0bda9d8
if [ -z $VELERO_RELEASE ] || [ -z $OPENEBS_RELEASE ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
velero-plugin/script/install-openebs.sh
Line 17 in 0bda9d8
if [ -z $VELERO_RELEASE ] || [ -z $OPENEBS_RELEASE ]; then |
0bda9d8
to
e5d4110
Compare
Test is failing because it's waiting for |
e5d4110
to
e874f78
Compare
The installation itself is installing cstor https://raw.githubusercontent.com/openebs/openebs/v3.10.0/k8s/openebs-operator.yaml and there is a lot of cstor stuff. Since cstor is deprecated, I wonder if continuing this repo makes sense. |
3632b85
to
2868876
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
velero-plugin/script/install-openebs.sh
Line 50 in 2868876
replicas=$(kubectl get deployment -n ${NS} ${DEPLOY} -o json | jq ".status.readyReplicas") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
velero-plugin/script/install-openebs.sh
Line 50 in 2868876
replicas=$(kubectl get deployment -n ${NS} ${DEPLOY} -o json | jq ".status.readyReplicas") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
velero-plugin/script/install-openebs.sh
Line 55 in 2868876
if [ ${DEPLOY} != "maya-apiserver" ] && [ ${DEPLOY} != "openebs-provisioner" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
velero-plugin/script/install-openebs.sh
Line 55 in 2868876
if [ ${DEPLOY} != "maya-apiserver" ] && [ ${DEPLOY} != "openebs-provisioner" ]; then |
b477fc8
to
73abf38
Compare
@@ -37,7 +38,7 @@ function waitForDeployment() { | |||
fi | |||
|
|||
for i in $(seq 1 50) ; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
73abf38
to
c420ba7
Compare
773f2e1
to
7a60191
Compare
Signed-off-by: sinhaashish <[email protected]>
7a60191
to
4c3b225
Compare
Pull Request template
Please, go through these steps before you submit a PR. ## Remove this line
Why is this PR required? What issue does it fix?:
update minikube version to run ci tests
What this PR does?:
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered and commands you used for testing with logs:
Any additional information for your reviewer?:
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>
PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING
PR title/commit message must follow convention:
<type>(<scope>): <subject>
.IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.