feat(helm): add support for providing additional volumes and adding init containers #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Nelson <[email protected]>
|
Why is this change required? |
|
@niladrih This is required for our usecase because we would like to automatically bootstrap the nodes with the setup required for zfs. Currently, we are doing this via a daemon set that runs an init container and then a pause container(simply because a container is required). It would be simpler if we could just specify an init container to run within the node and controller deployments. |
| @@ -38,6 +38,13 @@ spec: | |||
| priorityClassName: {{ template "zfslocalpv.zfsController.priorityClassName" . }} | |||
| {{- end }} | |||
| serviceAccount: {{ .Values.serviceAccount.zfsController.name }} | |||
| {{- if .Values.zfsController.initContainers }} | |||
There was a problem hiding this comment.
Should add initContainers and additionalVolumes to values.yaml with [] default.
Signed-off-by: Jesse Nelson <[email protected]>
|
These changes have been included in #461, closing this one. This is available in the released version v2.3.0. |
|
These changes were added to 2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
Adds support for additional volumes and init containers
What this PR does?:
Updates deployment yaml to support volume and init container config via values.yaml
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
deployed helm chart with various init containers and additional volumes.
Verified init containers executed correctly.
Any additional information for your reviewer? :
Checklist:
<type>(<scope>): <subject>