-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(csi): bump up csi provisioner to v3.5.0 and other updates #457
Conversation
Reason: - v1 CSIStorageCapacity is GA since K8s 1.24 and in csi-provisioner 3.2.0 and above. - In K8s 1.27 v1beta1/CSIStorageCapacity has been removed, so bumping this up will enable zfs-localpv to run on K8s 1.27 & above. Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]>
Is the below PR description correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor comment.
Lgtm
No @avishnu, the csi-provisioner version has been bumped up to 3.5.0 in line with other bump ups in other storage engines. Anything over 3.2.0(inclusive) i.e. [Edit]: refer to commit --> feat(deploy): update CSI sidecars & snapshot CRDs to latest |
I edited the 3.2.0 from your PR comment to 3.0.0. I think it meant there was a commit updating the PR (which initially bumped provisioner to 3.2.0). |
I meant the linguistic bit. Should it be "from" 3.0.0 "to" 3.5.0? |
Right, the description is now updated by @niladrih |
Closing this as the changes have been cherry-picked in #461 |
Reason:
Pull Request template
Why is this PR required? What issue does it fix?:
What this PR does?:
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Checklist:
<type>(<scope>): <subject>