-
Notifications
You must be signed in to change notification settings - Fork 424
Support mongosh #1265
Support mongosh #1265
Conversation
Thanks for the pull request, @DanielVZ96! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Test provisioning fails because it can't install google-cloud-sdk
|
@DanielVZ96 the latest versions of devstack remove that call, so you might just need to rebase off the most version of devstack to get rid of it: #1190 |
upgrade_mongo_5_0.sh
Outdated
#!/usr/bin/env bash | ||
set -eu -o pipefail | ||
|
||
# This script will upgrade a devstack that was previosly running Mongo DB 4.0 to MongoDB 4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version in the comment is out of date on the upgrade scripts.
# This script will upgrade a devstack that was previosly running Mongo DB 4.0 to MongoDB 4.0 | |
# This script will upgrade a devstack that was previosly running Mongo DB 4.x to MongoDB 5.x |
@dianakhuang thanks for the tip! I cherry picked the fix, let me know if you want a different order for the commits. @timmc-edx I updated the comments Edit: I'm a bit stuck on getting CI running. I've been making slow progress but now LMS fails the healthcheck
|
8c3f354
to
1703e9d
Compare
Hey @DanielVZ96, just to clarify, would you like to get more input from your reviewers on the CI issue that you mentioned above? Or were you just giving an update about what you're currently working on? The answer to that question will determine whether or not it's appropriate for this PR to be labeled as |
1703e9d
to
c7b0715
Compare
@itsjeyd at first I wanted more input, but now I just rebased my branch to master and started working from there. |
We can close this, as the devstack repo should be archived soon. |
@DanielVZ96 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
The
mongo
CLI utility is being deprecated in 5.0 and fully removed in mongo 6.0, and replaced withmongosh
. This PR addsmongosh
compatibility and also adds upgrade scripts up to 7.0.Testing
upgrade_mongo_5_0.sh
scripts up untilupgrade_mongo_7_0.sh
.I've completed each of the following or determined they are not applicable: