This repository has been archived by the owner on May 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhan-arshad-dev
suggested changes
Feb 20, 2024
OpenEdXMobile/src/main/java/org/edx/mobile/model/iap/IAPFlowData.kt
Outdated
Show resolved
Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/model/api/EnrolledCoursesResponse.kt
Outdated
Show resolved
Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/viewModel/InAppPurchasesViewModel.kt
Show resolved
Hide resolved
farhan-arshad-dev
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall code LGTM 🚀 , and executed the happy path using the hardcoded values. but still need a proper manual testing process by the QA team.
HamzaIsrar12
force-pushed
the
hamza/LEARNER-9818
branch
from
February 21, 2024 10:27
cc4deb8
to
f8c22ec
Compare
Introduce consumable In-App Purchase (IAP) functionality to overcome the 1000-product limit on the Play Console. This includes: - Adding a new field, `storeSku`, to store the Play Console product ID. The `storeSku` is derived from the combination of the `product_prefix` value from Remote Config and `min_price` from course modes in the enrolments API. - Implementing the process of consuming the product after verifying the purchase. Fixes: LEARNER-9818
The billing SDK's queryPurchases returns a list of purchases that are currently in a purchased, pending, or unspecified state. For the unfulfilled purchase flow, we only need to consider the 'purchased' state. Fixes: LEARNER-9878
HamzaIsrar12
force-pushed
the
hamza/LEARNER-9818
branch
from
March 5, 2024 21:57
a49428d
to
d74b621
Compare
farhan-arshad-dev
approved these changes
Mar 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LEARNER-9818 | LEARNER-9878
Remote Config Changes for Store SKU
The
storeSku
will be the combination ofprodcut_prefix
value from Remote Config andmin_price
from course modes in enrolments API.Implementation
Fetch the
courseSku
andstoreSku
using the enrollments API.Utilize the
courseSku
for theadd_to_basket
andcheckout
APIs.Handling Play Console purchases:
courseSku
within the purchase as a payload usingobfuscatedProfileId
(ref).storeSku
for the purchase.After a successful purchase:
courseSku
fromobfuscatedProfileId
.storeSku
from the product ID.Share this information with the
execute
API:consume the purchase
.In case of a restore (payment done, but execute API or consume not called):
Tada!!
References