chore(deps): update paragon and frontend-build to openedx scope #848
Conversation
|
@zubair-ce07 I see you approved #846, however, it is currently failing CI due to allowlist issues. This PR resolves those issues. If you could review/merge this PR so that one can be rebased that would be incredibly helpful. Thanks! |
|
@openedx/revenue-squad is anyone available to review/merge this? It resolves the allowlist audit problem that is causing #846 to fail CI. |
There was a problem hiding this comment.
Thanks @brian-smith-tcril ! I've checked the code. I have one question, but it looks good to me.
| "@edx/frontend-component-footer": "13.0.2", | ||
| "@edx/frontend-component-header": "5.0.2", | ||
| "@edx/frontend-platform": "7.1.0", |
There was a problem hiding this comment.
Are these imports supposed to stay @edx?
There was a problem hiding this comment.
Yes. As of writing, all 3 are still being published to @edx
https://github.com/openedx/frontend-component-footer/blob/62bf038a06feac7865e558205b29bc726e9594c4/package.json#L2
https://github.com/openedx/frontend-component-header/blob/3b2a2bfa9576926fcf6278b222835d68752bba0e/package.json#L2
https://github.com/openedx/frontend-platform/blob/f0e120244bb367b524c72ba30ef7e09c6b2cbcfc/package.json#L2
There was a problem hiding this comment.
Thanks @brian-smith-tcril. Any chance we could merge this pull request?
cc: @zubair-ce07
brian-smith-tcril
force-pushed
the
scope-build-paragon
branch
from
f95f3c0
to
cd38464
Compare
|
@brian-smith-tcril Would it be acceptable if I cherry-pick this commit, test it locally on my machine and include it into #846 It's the only remaining PR of ~15 other PRs that has been merged. cc: @revenue-squad @zubair-ce07 @sarina |
|
Thanks @zubair-ce07!! |
|
@zubair-ce07 - only people on the Revenue squad can merge PRs to this repo. Could you merge ASAP? |
Yes sure 👍 |
This fixes an issue that is currently causing all PRs to this repo to fail
This is blocking #846 which also needs to get merged ASAP
Includes all changes from #838, but also updates
frontend-component-header,frontend-component-footer, andfrontend-platformto versions with updated peer dependencies that use the@openedxscope.