-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: pymongo requires pymongo.collection import #28
Conversation
Thanks for the pull request, @jikamens! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
The current version of pymongo doesn't define `pymongo.collection` unless you import it explicitly.
@mphilbrick211 ping |
Thanks, @jikamens! This repo is currently unmaintained, so I've marked it for our Core Contributors to take a look at. Apologies for the delay! |
Hey @jikamens , thanks for the fix. I think this looks good. Before I merge, though, can you tell me how you noticed this? Is it an error you were seeing in LMS/Studio? |
I don't know what LMS/Studio is. I use MongoDBProxy in my own project. I noticed the problem after upgrading PyMongo in my project. |
Gotcha. What pymongo version did you upgrade to that required this fix? |
4.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, edx-platform uses 4.4.0, which seems to be compatible with or without your PR. So, this is good to merge. Thanks @jikamens .
The current version of pymongo doesn't define
pymongo.collection
unless you import it explicitly.