Add email notification flow to add verticals for new products #4549
+191
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza-56
changed the title
| if instance.draft or not created: | ||
| return | ||
|
|
||
| management_groups = getattr(settings, 'VERTICALS_MANAGEMENT_GROUPS', []) |
There was a problem hiding this comment.
should it not be a single group?
course_discovery/apps/course_metadata/templates/course_metadata/email/vertical_assigment.html
Outdated
Show resolved
Hide resolved
hamza-56
force-pushed
the
hamza/PROD-4283
branch
from
50e7a58 to
369e829
Compare
This is not addressed and hence, not ready for re-review. |
hamza-56
force-pushed
the
hamza/PROD-4283
branch
2 times, most recently
from
a58b093 to
c0ed45b
Compare
Ali-D-Akbar
reviewed
Jan 29, 2025
course_discovery/apps/course_metadata/templates/course_metadata/email/vertical_assigment.html
Outdated
Show resolved
Hide resolved
hamza-56
force-pushed
the
hamza/PROD-4283
branch
3 times, most recently
from
649f2e1 to
a1ef58b
Compare
Ali-D-Akbar
approved these changes
Jan 29, 2025
| @@ -0,0 +1,11 @@ | |||
| {% extends "course_metadata/email/email_base.html" %} | |||
There was a problem hiding this comment.
the template path should be template/tagging/email/vertical_assignment.html. The app name directory should be there as per best/recommended practice https://learndjango.com/tutorials/template-structure.
There was a problem hiding this comment.
We are using Option 1: App Level Templates. And our template is in
course_discovery/apps/tagging/templates/email/update_course_verticals.html
hamza-56
force-pushed
the
hamza/PROD-4283
branch
from
a1ef58b to
b769fc5
Compare
DawoudSheraz
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-4283
Add email notification flow to add verticals for new products