Skip to content

Commit

Permalink
fixup! use updated name of method
Browse files Browse the repository at this point in the history
  • Loading branch information
robrap authored Nov 28, 2023
1 parent 27f789a commit 044ea74
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/decisions/0002-remove-use-jwt-cookie-header.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Decision

Replace the ``HTTP_USE_JWT_COOKIE`` header with forgiving authentication when using JWT cookies. By "forgiving", we mean that JWT authentication would no longer raise exceptions for failed authentication when using JWT cookies, but instead would simply return None.

By returning None from JwtAuthentication, rather than raising an authentication failure, we enable services to move on to other classes, like SessionAuthentication, rather than aborting the authentication process. Failure messages could still be surfaced using `set_custom_metric` for debugging purposes.
By returning None from JwtAuthentication, rather than raising an authentication failure, we enable services to move on to other classes, like SessionAuthentication, rather than aborting the authentication process. Failure messages could still be surfaced using ``set_custom_attribute`` for debugging purposes.

Rather than checking for the ``HTTP_USE_JWT_COOKIE``, the `JwtAuthCookieMiddleware`_ would always reconstitute the JWT cookie if the parts were available.

Expand Down

0 comments on commit 044ea74

Please sign in to comment.