Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JwtAuthentication with Django request #406

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

robrap
Copy link
Contributor

@robrap robrap commented Nov 14, 2023

Description:

Fixed bug where JwtAuthentication called with a Django request instead of a DRF request would fail. Also added custom attribute jwt_auth_request_user_not_found to track down these unexpected cases.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bump if needed
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Fixed bug where JwtAuthentication called with a Django request
instead of a DRF request would fail. Also added custom attribute
jwt_auth_request_user_not_found to track down these unexpected
cases.
@robrap robrap requested a review from feanil November 14, 2023 23:02
@robrap robrap merged commit 3b36633 into master Nov 15, 2023
7 checks passed
@robrap robrap deleted the robrap/fix-jwt-auth branch November 15, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants