fix: bug with service user id vs lms user id #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrap
commented
Dec 5, 2023
timmc-edx
approved these changes
Dec 6, 2023
- Fixed bug for successful JWTs where the JWT user id was still using the service user id, rather than the LMS user id, so comparison against the LMS user id would fail. - As part of the bug fix, the custom attribute ``failed_jwt_cookie_user_id`` was renamed to ``jwt_cookie_lms_user_id``, and will be set for all JWT cookies. Since this is only a breaking change for recently added monitoring, this won't be versioned as a breaking change. This is part of: edx/edx-arch-experiments#429
Fix the readthedocs config.
robrap
force-pushed
the
robrap/fix-session-jwt-mismatch
branch
from
f7dd5a9 to
09d2079
Compare
robrap
added a commit
to robrap/ecommerce
that referenced
this pull request
Dec 6, 2023
9.0.1 fixes ENABLE_FORGIVING_JWT_COOKIES bug. This build on the 9.0.0 fix, but applies the fix to another place where the JWT's LMS user id will be compared in place of the newly authenticated service user's id. For details, see: openedx/edx-drf-extensions#414 Note that this won't be put into effect until ENABLE_FORGIVING_JWT_COOKIES is toggled on separately. This is part of the rollout of: edx/edx-arch-experiments#429
2 tasks
christopappas
pushed a commit
to openedx-unsupported/ecommerce
that referenced
this pull request
Dec 6, 2023
9.0.1 fixes ENABLE_FORGIVING_JWT_COOKIES bug. This build on the 9.0.0 fix, but applies the fix to another place where the JWT's LMS user id will be compared in place of the newly authenticated service user's id. For details, see: openedx/edx-drf-extensions#414 Note that this won't be put into effect until ENABLE_FORGIVING_JWT_COOKIES is toggled on separately. This is part of the rollout of: edx/edx-arch-experiments#429
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
using the service user id, rather than the LMS user id, so comparison
against the LMS user id would fail.
failed_jwt_cookie_user_idwas renamed tojwt_cookie_lms_user_id, and will be set for all JWT cookies.Since this is only a breaking change for recently added monitoring,
this won't be versioned as a breaking change.
This is part of:
edx/edx-arch-experiments#429
Merge checklist:
Post merge:
finished.