Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try calling set_code_owner inside task #2084

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rgraber
Copy link

@rgraber rgraber commented Oct 20, 2023

TL;DR - Replaces set_code_owner_attribute decorator with a manual call to set_code_owner_attribute_from_module because the decorator isn't working for some reason

Developer Checklist

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a2f652a) 94.93% compared to head (0f985e3) 94.91%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2084      +/-   ##
==========================================
- Coverage   94.93%   94.91%   -0.03%     
==========================================
  Files         183      183              
  Lines       18634    18636       +2     
  Branches     1704     1704              
==========================================
- Hits        17690    17688       -2     
- Misses        712      716       +4     
  Partials      232      232              
Flag Coverage Δ
unittests 94.91% <63.63%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
openassessment/__init__.py 100.00% <100.00%> (ø)
openassessment/xblock/test/test_submission.py 100.00% <100.00%> (ø)
openassessment/workflow/tasks.py 45.45% <20.00%> (-18.19%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rgraber rgraber changed the title feat: try calling set_code_owner inside task fix: try calling set_code_owner inside task Oct 20, 2023
@timmc-edx
Copy link

This seems to have worked: edx/edx-arch-experiments#482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants