Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the unused edx-custom-a11y-rules package. #34981

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Jun 13, 2024

This package was only used by bok-choy which was archived a while ago.
We just missed the fact that this package was also a node dependency.

See openedx/public-engineering#13 for more
details.

feanil added 2 commits June 13, 2024 07:42
This package was only used by bok-choy which was archived a while ago.
We just missed the fact that this package was also a node dependency.

See openedx/public-engineering#13 for more
details.
@feanil feanil marked this pull request as ready for review June 13, 2024 11:58
@feanil feanil requested a review from kdmccormick June 13, 2024 11:59
Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feanil feanil merged commit 6c2cf87 into master Jun 13, 2024
46 checks passed
@feanil feanil deleted the feanil/remove_unnecessary_package branch June 13, 2024 16:24
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants