fix: remove the "Legacy Library" button if libraries v1 are disabled [FC-0062]

[pomegranited]

Description

Removes the "Legacy Library" button from the legacy Studio "new block" button array if Libraries v1 are disabled, either via waffle flag or via the ENABLE_CONTENT_LIBRARIES feature flag.

All libraries enabled (default):

Libraries v1 only enabled:

Libraries v2 only enabled:

No libraries enabled:

Supporting information

Addresses: openedx/modular-learning#237
Private-ref: FAL-3855

Testing instructions

1. Disable the contentstore.new_studio_mfe.use_new_unit_page Waffle flag to access the legacy Studio Unit page for a course.
2. Change the settings for the contentstore.new_studio_mfe.disable_new_libraries (v2 libraries) and contentstore.new_studio_mfe.disable_legacy_libraries (v1 libraries) waffle flags to toggle support for the various libraries content buttons.
   If contentstore.new_studio_mfe.disable_new_libraries is disabled, the Libraries v2 buttons for "Library Content (beta)" and "Problem Bank (beta)" should be shown.
   If contentstore.new_studio_mfe.disable_legacy_libraries is disabled, the "Legacy Library" button should be shown.
3. Change settings.FEATURES['ENABLE_CONTENT_LIBRARIES'] = False
   This disables both libraries v1 + v2, so all 3 buttons should be removed, regardless of the relevant waffle flags.

Deadline

ASAP

[openedx-webhooks]

Thanks for the pull request, @pomegranited!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[rpenido]

LGTM 👍
Thank you for your work, @pomegranited!

• I tested this using the instructions from the PR
• I read through the code
• I checked for accessibility issues N/A
• Includes documentation

[ChrisChV]

Looks good! I will merge it tomorrow morning

[ChrisChV]

Hi @pomegranited, what happened with this PR, why has it been closed?

[pomegranited]

Ach sorry @ChrisChV -- I cleaned up a bunch of unused branches and must have deleted this one :(
Ready for your review!

[ChrisChV]

Ach sorry @ChrisChV -- I cleaned up a bunch of unused branches and must have deleted this one :(
Ready for your review!

Ok @pomegranited, no problem. I will merge this tomorrow morning

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.