feat: Changes in xblock_v2 to support studio_view [FC-0076] #36029
Conversation
|
Thanks for the pull request, @ChrisChV! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
ChrisChV
changed the title
ChrisChV
added
the
waiting for eng review
| event.preventDefault(); | ||
| window.parent.postMessage('save-clicked', '*'); | ||
| }); | ||
| </script> |
There was a problem hiding this comment.
I'm surprised this works. Doesn't this run before the cancel button and save button are even added to the document? Are we sure this will always run after they are added ?
There was a problem hiding this comment.
Also, we probably want to find some way to make this code only run in studio_view, not any other view.
There was a problem hiding this comment.
Also: how does saving actually work? What code is handling the "Save" button and actually saving the changes?
There was a problem hiding this comment.
Also, we probably want to find some way to make this code only run in studio_view, not any other view.
Updated. I verified the view_name
Are we sure this will always run after they are added ?
I refactored the code with a better approach. About cancel, I moved the code after the block is rendered. About save, I used the notify function to catch the end of the save and send a message to the MFE. I chose this approach because it solves a bug when saving: The iframe was closing before the save operation was finished.
how does saving actually work? What code is handling the "Save" button and actually saving the changes?
Each block type has its own code and logic for saving, but they all have in common the notify at the end of the save and call the studio_submit handler, using xblock_handler
…nts on block render
Description
Updates to support
studio_view(editors) in xblock_v2 iframe.studio_viewnotifyfunction inruntime. This is to avoid errors when saving the XblockSupporting information
Testing instructions
Follow the testing instructions at openedx/frontend-app-authoring#1568
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
N/A