Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INCR-85] Support testing Python 3 in edx-search #63

Merged
merged 14 commits into from
Feb 22, 2019
Merged

[INCR-85] Support testing Python 3 in edx-search #63

merged 14 commits into from
Feb 22, 2019

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 22, 2019 •
edited
Loading

@openedx-webhooks
Copy link

Thanks for the pull request, @cclauss! I've created OSPR-3115 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Feb 22, 2019
@natabene
Copy link

@cclauss Thank you for your contribution. Please let me know once it all checks are green and it is ready for review. Thanks

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Feb 22, 2019
jmbowman
jmbowman reviewed Feb 22, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
jmbowman
jmbowman approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@jmbowman jmbowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Codecov passed, but the GitHub app wasn't connected to this repo so the results weren't reported back; just fixed that. The coverage report is at https://codecov.io/gh/edx/edx-search/pull/63

@jmbowman jmbowman merged commit f750326 into openedx:master Feb 22, 2019
@openedx-webhooks
Copy link

@cclauss 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@cclauss cclauss deleted the patch-1 branch February 22, 2019 18:22
@openedx-webhooks openedx-webhooks added merged and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Jan 22, 2021
salman2013 pushed a commit that referenced this pull request Jun 21, 2023
@cclauss
[INCR-85] Support testing Python 3 in edx-search (#63)
70eddcd 
* [INCR-85] Support testing Python 3 in edx-search

* envlist = py27-django111,py{36,37}-django{111,20,21}, quality

* pep8 --> pycodestyle

* pycodestyle==2.5.0

* Remove trailing whitespace to placate pycodestyle

* test_requirements.txt: Add pylint

* Add pylint-django

* Fix pylint-django versions

* No dist: xenial

* from django.http import JsonResponse

* return JsonResponse(results, status=status_code)

* Remove allow_failures on legacy Python quality

* Update .travis.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmbowman jmbowman jmbowman approved these changes

Assignees
No one assigned
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cclauss @openedx-webhooks @natabene @jmbowman