Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds sorting and search functionality #1379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Jan 11, 2025

Description

Adds sorting and search functionality to the enterprise members table.
https://2u-internal.atlassian.net/browse/ENT-9861

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 marked this pull request as ready for review January 11, 2025 00:41
@katrinan029 katrinan029 requested a review from a team January 11, 2025 00:42
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.69%. Comparing base (0716be5) to head (3adbab2).

Files with missing lines Patch % Lines
...gement/data/hooks/useEnterpriseMembersTableData.js 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1379      +/-   ##
==========================================
- Coverage   85.71%   85.69%   -0.03%     
==========================================
  Files         625      625              
  Lines       13638    13644       +6     
  Branches     2856     2855       -1     
==========================================
+ Hits        11690    11692       +2     
- Misses       1878     1881       +3     
- Partials       70       71       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant