-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upload images from the TinyMCE in library editor #1458
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @dcoa! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
b8d3291
to
f8a53ad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1458 +/- ##
==========================================
+ Coverage 93.25% 93.28% +0.03%
==========================================
Files 1052 1053 +1
Lines 20458 20529 +71
Branches 4382 4318 -64
==========================================
+ Hits 19078 19151 +73
- Misses 1317 1318 +1
+ Partials 63 60 -3 ☔ View full report in Codecov by Sentry. |
4b3bd8c
to
e276e00
Compare
e276e00
to
2ebb15c
Compare
Description
This PR allows to upload images from the TinyMCE component.
The changes allows:
What is not cover?
Supporting information
See the issue for more context #1398.
Testing instructions
problem
ortext
from the content options2024-11-06.00-45-59.mov