Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upload images from the TinyMCE in library editor #1458

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dcoa
Copy link
Contributor

@dcoa dcoa commented Nov 4, 2024

Description

This PR allows to upload images from the TinyMCE component.

The changes allows:

  • Update images from Libraries V2
  • Maintain the same behavior as courses, load the image and open a new modal view for setting configuration.
  • List the images for the block.

What is not cover?

  • Libraries V1 is not supported in this PR, so the button is hidden for that version.
  • Sort and filter is included in the modal

Supporting information

See the issue for more context #1398.

Testing instructions

  • Create a instance that supports libraries V2
  • Create a new Library
  • Chose the problem or text from the content options
  • The image button is visible.
  • Upload a image
2024-11-06.00-45-59.mov

@openedx-webhooks
Copy link

openedx-webhooks commented Nov 4, 2024

Thanks for the pull request, @dcoa!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 4, 2024
@dcoa dcoa force-pushed the dcoa/tinymce-images-upload branch 4 times, most recently from b8d3291 to f8a53ad Compare November 4, 2024 20:46
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.28%. Comparing base (ecfe27b) to head (2ebb15c).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1458      +/-   ##
==========================================
+ Coverage   93.25%   93.28%   +0.03%     
==========================================
  Files        1052     1053       +1     
  Lines       20458    20529      +71     
  Branches     4382     4318      -64     
==========================================
+ Hits        19078    19151      +73     
- Misses       1317     1318       +1     
+ Partials       63       60       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcoa dcoa changed the title [WIP] feat: upload images from the modal editor in libraries [WIP] feat: upload images from the TinyMCE in library Nov 5, 2024
@dcoa dcoa force-pushed the dcoa/tinymce-images-upload branch from 4b3bd8c to e276e00 Compare November 5, 2024 13:55
@dcoa dcoa force-pushed the dcoa/tinymce-images-upload branch from e276e00 to 2ebb15c Compare November 5, 2024 14:04
@dcoa dcoa changed the title [WIP] feat: upload images from the TinyMCE in library feat: upload images from the TinyMCE in library Nov 5, 2024
@dcoa dcoa marked this pull request as ready for review November 5, 2024 14:05
@dcoa dcoa requested a review from a team as a code owner November 5, 2024 14:05
@dcoa dcoa changed the title feat: upload images from the TinyMCE in library feat: upload images from the TinyMCE in library editor Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants