-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: block overflow when editing comment #706
base: master
Are you sure you want to change the base?
fix: block overflow when editing comment #706
Conversation
Thanks for the pull request, @ihor-romaniuk! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @openedx/2u-infinity @openedx/edx-infinity! This, along with it's backport are ready for review. Thanks! |
Sandbox deployment successful 🚀 |
Sandbox deployment successful 🚀 |
Sandbox deployment failed 💥 |
Sandbox deployment failed 💥 |
Sandbox deployment successful 🚀 |
a512e2d
to
63beafb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #706 +/- ##
=======================================
Coverage 93.18% 93.18%
=======================================
Files 161 161
Lines 3404 3404
Branches 914 919 +5
=======================================
Hits 3172 3172
Misses 215 215
Partials 17 17 ☔ View full report in Codecov by Sentry. |
Sandbox deployment successful 🚀 |
Hi @openedx/2u-infinity - are you still maintaining this repo? If so, would you mind taking a look? Thanks! |
Yes, We are still managing this repo. I'll review it. |
63beafb
to
17884d6
Compare
@awais-ansari I believe everything is ready for merging of this pull request and of the backport pull request #705 as well. Could we proceed with that? |
Sandbox deployment successful 🚀 |
17884d6
to
2e4b9dd
Compare
Sandbox deployment successful 🚀 |
Sandbox deployment successful 🚀 |
@awais-ansari: could you please help us merge this PR and the backport? Thanks! |
Sandbox deployment successful 🚀 |
Sandbox deployment successful 🚀 |
Sandbox deployment successful 🚀 |
@ihor-romaniuk Could you please rebase this PR? |
Description
This merge request contains a fix for the comment edit block width at small screen resolutions for course Discussions pages or discussion sidebar in MFE Learning.
Related PR
Screenshots: