fix: max adjusted grades warning and error

[lkatsikaris]

Fix: message error if the input is greater than the adjusted grade.

Fixes #394

What changed?

• Fixed the adjusted grade by comparing the input value with the possibleGrade (the maximum grade can take) and enabling the save button only if the value is minor than the possibleGrade.
• Modify the useAdjustedGradeInputData hook to return the possible grade that we need in the comparison above.

Developer Checklist

• Test suites passing
• Documentation and test plan updated, if applicable
• Received code-owner approving review
• Bumped version number package.json

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

• I've done a visual code review
• I've tested the new functionality

FYI: @openedx/content-aurora

[openedx-webhooks]

Thanks for the pull request, @lkatsikaris!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @farhaanbukhsh. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[mphilbrick211]

Hi @lkatsikaris, and thank you for this contribution! It looks like you are contributing on behalf of Aulasneo, correct? If so, please have your manager reach out to [email protected] to be added to our existing entity CLA with Aulasneo.

[sarina]

@mariajgrimaldi is this a new feature, or is this a bugfix? The original issue linked is openedx/wg-build-test-release#357 which implies this is a test failure fix.

[mariajgrimaldi]

@sarina: the "test failure" issue is labeled as enhancement, so no it's not a bugfix. I will close the test failure issue since the enhancement has already been addressed here.

[sarina]

Gotcha. This enhancement seems reasonable to me but I'm not sure why all the dependencies were updated - that shouldn't be a part of the PR.

…

On Fri, Oct 18, 2024, 04:37 Maria Grimaldi ***@***.***> wrote: @sarina <https://github.com/sarina>: the "test failure" issue is labeled as *enhancement*, so no it's not a bugfix. I will close the test failure issue since the enhancement has already been addressed here. — Reply to this email directly, view it on GitHub <#402 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPEWJNKJS4YVCP76VN6TVTZ4DCD3AVCNFSM6AAAAABNGCUORWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRRHAZTQMBXGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[sarina]

@lkatsikaris - can you address comments and remove the updates to the dependency file? And rebase your branch to get the latest updates.

[sarina]

Is there a way to do string interpolation with the grade value? This won't render properly for some languages, including RTL languages like Arabic

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (997d205) to head (32ccae5).
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   94.98%   94.99%   +0.01%     
==========================================
  Files         139      139              
  Lines        1356     1359       +3     
  Branches      265      266       +1     
==========================================
+ Hits         1288     1291       +3     
  Misses         60       60              
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[farhaanbukhsh]

@lkatsikaris any updates here? Do you need help?

[farhaanbukhsh]

@lkatsikaris you should check why are the snapshots being updated. Is it because of the changes you made or something else?

[lkatsikaris]

@lkatsikaris you should check why are the snapshots being updated. Is it because of the changes you made or something else?

Yes, I had to update the snapshots to pass the make test command