chore: cover useSubscriptions select fn with bff data

openedx · Dec 16, 2024 · fb9b704 · fb9b704
1 parent b806a0f
commit fb9b704
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/src/components/dashboard/main-content/course-enrollments/data/hooks.js b/src/components/dashboard/main-content/course-enrollments/data/hooks.js
@@ -150,10 +150,13 @@ export const useCourseUpgradeData = ({
   const location = useLocation();
   const canUpgradeToVerifiedEnrollment = isEnrollmentUpgradeable({ mode, enrollBy });
   const { data: enterpriseCustomer } = useEnterpriseCustomer();
+
+  // Metadata required to determine if the course run is contained in the customer's content catalog(s)
   const { data: customerContainsContent } = useEnterpriseCustomerContainsContent([courseRunKey], {
     enabled: canUpgradeToVerifiedEnrollment,
   });
 
+  // Metadata required to allow upgrade via applicable learner credit subsidy
   const { data: learnerCreditMetadata } = useCanUpgradeWithLearnerCredit(courseRunKey, {
     enabled: canUpgradeToVerifiedEnrollment,
   });
@@ -162,7 +165,8 @@ export const useCourseUpgradeData = ({
   const { data: subscriptionLicense } = useSubscriptions({
     select: (data) => {
       let license;
-      if (data.transformed) {
+      if (data?.transformed) {
+        // If the data has been transformed, use the transformed data.
         license = data.transformed.subscriptionLicense;
       } else {
         license = data?.subscriptionLicense;

diff --git a/src/components/dashboard/main-content/course-enrollments/data/tests/hooks.test.jsx b/src/components/dashboard/main-content/course-enrollments/data/tests/hooks.test.jsx
@@ -366,11 +366,18 @@ describe('useCourseUpgradeData', () => {
         }),
       );
       const useSubscriptionsSelectFn = useSubscriptions.mock.calls[0][0].select;
-      const selectTransformResult = useSubscriptionsSelectFn({ subscriptionLicense: mockSubscriptionLicense });
+      const selectTransformResultLegacy = useSubscriptionsSelectFn({ subscriptionLicense: mockSubscriptionLicense });
+      const transformedSubscriptionsBFFData = {
+        original: { subscriptionLicense: mockSubscriptionLicense },
+        transformed: { subscriptionLicense: mockSubscriptionLicense },
+      };
+      const selectTransformResultBFF = useSubscriptionsSelectFn(transformedSubscriptionsBFFData);
       if (subscriptionLicenseStatus === LICENSE_STATUS.ACTIVATED && isSubscriptionPlanCurrent) {
-        expect(selectTransformResult).toEqual(mockSubscriptionLicense);
+        expect(selectTransformResultLegacy).toEqual(mockSubscriptionLicense);
+        expect(selectTransformResultBFF).toEqual(mockSubscriptionLicense);
       } else {
-        expect(selectTransformResult).toBeNull();
+        expect(selectTransformResultLegacy).toBeNull();
+        expect(selectTransformResultBFF).toBeNull();
       }
 
       // Assert expected output