-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update course about sidebar to take into account usd fixed price #1199
Conversation
ddb5e92
to
d1b7ac8
Compare
d1b7ac8
to
4a60624
Compare
c852bc0
to
4f59aef
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1199 +/- ##
==========================================
- Coverage 88.42% 88.41% -0.02%
==========================================
Files 396 399 +3
Lines 8407 8500 +93
Branches 2059 2093 +34
==========================================
+ Hits 7434 7515 +81
- Misses 930 942 +12
Partials 43 43 ☔ View full report in Codecov by Sentry. |
4f7ee5c
to
65ad72c
Compare
65ad72c
to
bb53284
Compare
const seenExpiredSubscriptionModal = !!global.localStorage.getItem( | ||
EXPIRED_SUBSCRIPTION_MODAL_LOCALSTORAGE_KEY(subscriptionLicense), | ||
); | ||
const [isOpen, , close] = useToggle(!seenExpiredSubscriptionModal); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🙌
10ab993
to
818b606
Compare
818b606
to
4315514
Compare
src/components/app/data/hooks/useCourseRedemptionEligibility.js
Outdated
Show resolved
Hide resolved
src/components/app/data/hooks/useCourseRedemptionEligibility.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 1 addtl comment, around the rename from coursePrice.discountedList
-> coursePrice.discountedListRange
.
8329e2e
to
5fb9002
Compare
This change would take into account price ranges for the course sidebar based on the run price. 👍🏽
Example UI:
![Screenshot 2024-10-02 at 9 58 02 AM](https://private-user-images.githubusercontent.com/82611798/372890900-0e807b08-c018-4472-97da-64e713258124.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3NzM3NDUsIm5iZiI6MTczODc3MzQ0NSwicGF0aCI6Ii84MjYxMTc5OC8zNzI4OTA5MDAtMGU4MDdiMDgtYzAxOC00NDcyLTk3ZGEtNjRlNzEzMjU4MTI0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA1VDE2MzcyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU0MmFmMzBmOWYxMzMyMWUxYTI2NDQyOTIzZjZjMWQxMTBmNjllMGU1MDAzOGU4Yjg5OGRjMzBiNDBkOWE2NzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ejXORY6hagXh4DFmgVdow9QDGzzL4MNqVwYobuGG7IE)
[Bug fix]
Fixed a bug I ran into where the subscription expiration modal became a blocking modal.
For all changes
Only if submitting a visual change