fix: invalid date formatting on course route #1233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves "Invalid Date" messages on course about page in Learner Portal in Firefox (appears fine in Chrome). The error seems to be due to different browsers' parsing/handling of datetime strings.
Locally, there was a JS error triggers by
react-intl
'sFormattedDate
component:The solution was to ensure the raw date string was passed to
FormattedDate
vs. passing the already-formatted date viadayjs(...).format(DATE_FORMAT)
.This PR also switches to use
getNormalizedStartDate
within the deprecatedCourseRunCard
component to ensure today's date is used for display, where relevant (i.e., self-paced courses with time-to-complete).For all changes
Only if submitting a visual change