Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct usages of useEnterpriseFeatures #1240

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Dec 18, 2024

A previous PR incorrectly changed the expected data structure return value of the useEnterpriseFeatures hook. The hook returns a useQuery result, not a direct pass-thru of the enterpriseFeatures object as is currently assumed in the code per the prior PR.

This PR changes the usages of useEnterpriseFeatures back to the expected const { data: enterpriseFeatures } = useEnterpriseFeatures() throughout the application.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (dd0cb8d) to head (8d685a7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1240      +/-   ##
==========================================
+ Coverage   88.99%   89.02%   +0.03%     
==========================================
  Files         402      402              
  Lines        8721     8721              
  Branches     2083     2125      +42     
==========================================
+ Hits         7761     7764       +3     
+ Misses        919      916       -3     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz merged commit 400ae26 into master Dec 18, 2024
6 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/fix-usage-useEnterpriseFeatures branch December 18, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants