Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide video banner if no videos are available #1254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

omar-sarfraz
Copy link
Member

Ticket: ENT-9893

Description: Made some changes to hide videos' banner initially and display it only if videos' section is populated. For the Id's issue, I noticed that we are using hard-coded strings as Ids for Algolia's Index component. I have moved them to a separate file and these Ids are now being used in SearchResults component instead of using a simple Id based on showBetaBadge's boolean condition.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.50%. Comparing base (cf26017) to head (5e776c8).

Files with missing lines Patch % Lines
src/components/search/SearchResults.jsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
+ Coverage   89.47%   89.50%   +0.03%     
==========================================
  Files         404      405       +1     
  Lines        8741     8750       +9     
  Branches     2069     2112      +43     
==========================================
+ Hits         7821     7832      +11     
+ Misses        884      881       -3     
- Partials       36       37       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant