fix: error when navigating exam units #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharis278
force-pushed
the
zhancock/fix-navigation-error
branch
2 times, most recently
from
12233cd
to
a6f1dc4
Compare
zacharis278
force-pushed
the
zhancock/fix-navigation-error
branch
from
a6f1dc4
to
e6beffe
Compare
alangsto
approved these changes
Aug 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
- Coverage 87.67% 87.66% -0.01%
==========================================
Files 264 264
Lines 4453 4452 -1
Branches 1110 1110
==========================================
- Hits 3904 3903 -1
Misses 535 535
Partials 14 14
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MST-2029
This useEffect hook would occasionally cause React to choke. By returning a value here we're telling react to callback that function on cleanup, except we're returning a Promise not a function so it blows up. There's no need to return anything here.
There may be another issue or change that caused this problem to surface but this fixed the error for me locally.