Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for a technical support URL in the LTI-based provider download instructions #127

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

MichaelRoytman
Copy link
Contributor

@MichaelRoytman MichaelRoytman commented Dec 20, 2023

Description

Jira: COSMO-130
Dependencies: edx/edx-exams#231

This commit adds support for displaying a technical support URL for LTI-based providers on the download instructions interstitial. The download instructions will display a technical support URL when it is returned from the proctoring settings backend endpoint. If the technical support URL is not available, then the technical support email and technical support phone number will be used instead.

Screenshots

supportURL

image

supportEmail, supportPhone

image

no supportURL, supportEmail, supportPhone

image

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1d236a4) 94.10% compared to head (8a7e085) 93.95%.

❗ Current head 8a7e085 differs from pull request most recent head 141ea62. Consider uploading reports for the commit 141ea62 to get more accurate results

Files Patch % Lines
.../download-instructions/LtiProviderInstructions.jsx 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   94.10%   93.95%   -0.16%     
==========================================
  Files          71       71              
  Lines        1051     1058       +7     
  Branches      289      289              
==========================================
+ Hits          989      994       +5     
- Misses         57       59       +2     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

<FormattedMessage
id="exam.DownloadSoftwareProctoredExamInstructions.supportText"
id="exam.DownloadSoftwareProctoredExamInstructions.LTI.supportText.URL"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that there is a FormattedMessage in RestProviderInstructions.jsx with the same original ID (exam.DownloadSoftwareProctoredExamInstructions.supportText). Does anyone know if that would cause a conflict with this original string? I added LTI to differentiate, but I'm not sure if the strings end up namespaced by component or something.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also not sure but differentiating them seems wise

…er download instructions

This commit adds support for displaying a technical support URL for LTI-based providers on the download instructions interstitial. The download instructions will display a technical support URL when it is returned from the proctoring settings backend endpoint. If the technical support URL is not available, then the technical support email and technical support phone number will be used instead.
@MichaelRoytman MichaelRoytman force-pushed the michaelroytman/COSMO-130-tech-support-site branch from 8a7e085 to 141ea62 Compare December 20, 2023 16:27
<FormattedMessage
id="exam.DownloadSoftwareProctoredExamInstructions.supportText"
id="exam.DownloadSoftwareProctoredExamInstructions.LTI.supportText.URL"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also not sure but differentiating them seems wise

@MichaelRoytman MichaelRoytman merged commit 8457727 into main Dec 20, 2023
5 checks passed
@MichaelRoytman MichaelRoytman deleted the michaelroytman/COSMO-130-tech-support-site branch December 20, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants