-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for a technical support URL in the LTI-based provider download instructions #127
feat: add support for a technical support URL in the LTI-based provider download instructions #127
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 94.10% 93.95% -0.16%
==========================================
Files 71 71
Lines 1051 1058 +7
Branches 289 289
==========================================
+ Hits 989 994 +5
- Misses 57 59 +2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
<FormattedMessage | ||
id="exam.DownloadSoftwareProctoredExamInstructions.supportText" | ||
id="exam.DownloadSoftwareProctoredExamInstructions.LTI.supportText.URL" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that there is a FormattedMessage
in RestProviderInstructions.jsx
with the same original ID (exam.DownloadSoftwareProctoredExamInstructions.supportText
). Does anyone know if that would cause a conflict with this original string? I added LTI
to differentiate, but I'm not sure if the strings end up namespaced by component or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also not sure but differentiating them seems wise
…er download instructions This commit adds support for displaying a technical support URL for LTI-based providers on the download instructions interstitial. The download instructions will display a technical support URL when it is returned from the proctoring settings backend endpoint. If the technical support URL is not available, then the technical support email and technical support phone number will be used instead.
8a7e085
to
141ea62
Compare
<FormattedMessage | ||
id="exam.DownloadSoftwareProctoredExamInstructions.supportText" | ||
id="exam.DownloadSoftwareProctoredExamInstructions.LTI.supportText.URL" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also not sure but differentiating them seems wise
Description
Jira: COSMO-130
Dependencies: edx/edx-exams#231
This commit adds support for displaying a technical support URL for LTI-based providers on the download instructions interstitial. The download instructions will display a technical support URL when it is returned from the proctoring settings backend endpoint. If the technical support URL is not available, then the technical support email and technical support phone number will be used instead.
Screenshots
supportURL
supportEmail, supportPhone
no supportURL, supportEmail, supportPhone