-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: update dependencies to use @openedx
scope
#636
chore!: update dependencies to use @openedx
scope
#636
Conversation
9d252f4
to
47dfb3e
Compare
47dfb3e
to
858ddad
Compare
@openedx
scope
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #636 +/- ##
=======================================
Coverage 83.50% 83.50%
=======================================
Files 40 40
Lines 1073 1073
Branches 197 197
=======================================
Hits 896 896
Misses 165 165
Partials 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks, Brian.
package.json
Outdated
@@ -74,8 +74,8 @@ | |||
"universal-cookie": "4.0.4" | |||
}, | |||
"peerDependencies": { | |||
"@edx/frontend-build": ">= 8.1.0 || ^12.9.0-alpha.1", | |||
"@edx/paragon": ">= 10.0.0 < 22.0.0", | |||
"@openedx/frontend-build": ">= 8.1.0 || ^12.9.0-alpha.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@openedx/frontend-build doesn't have 12.9.0-alpha.7 build. It would crash for repos that use frontend-build alpha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the versions based on the lowest released versions in the openedx scope https://github.com/openedx/frontend-platform/compare/858ddad3f0490e3e40e992fb441b1ab57ba0a9cf..199a4b500583ed8693c77d44749d3bb19b4a6492
BREAKING CHANGE: consuming applications must now install `paragon` from the `@openedx` scope, `paragon` installed from the `@edx` scope will no longer satisfy the peer dependency BREAKING CHANGE: consuming applications must now install `frontend-build` from the `@openedx` scope, `frontend-build` installed from the `@edx` scope will no longer satisfy the peer dependency
858ddad
to
199a4b5
Compare
BREAKING CHANGE: consuming applications must now install `paragon` from the `@openedx` scope, `paragon` installed from the `@edx` scope will no longer satisfy the peer dependency BREAKING CHANGE: consuming applications must now install `frontend-build` from the `@openedx` scope, `frontend-build` installed from the `@edx` scope will no longer satisfy the peer dependency
BREAKING CHANGE: consuming applications must now install `paragon` from the `@openedx` scope, `paragon` installed from the `@edx` scope will no longer satisfy the peer dependency BREAKING CHANGE: consuming applications must now install `frontend-build` from the `@openedx` scope, `frontend-build` installed from the `@edx` scope will no longer satisfy the peer dependency
Part of openedx/axim-engineering#23 (comment)
Description:
BREAKING CHANGE: consuming applications must now install
paragon
from the@openedx
scope,paragon
installed from the@edx
scope will no longer satisfy the peer dependencyBREAKING CHANGE: consuming applications must now install
frontend-build
from the@openedx
scope,frontend-build
installed from the@edx
scope will no longer satisfy the peer dependencyMerge checklist:
frontend-platform
. This can be done by runningnpm start
and opening http://localhost:8080.module.config.js
file infrontend-build
.fix
,feat
) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: