Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bump): upgrade helm chart global dependencies #86

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Oct 3, 2024

Description

This PR upgrades the helm chart dependencies to the latest version.

Cert manager cannot be upgraded to v1.16 because of this bug: cert-manager/cert-manager#1829

The upgrade was already tested on a production k8s cluster by upgrading from the current version to the new one.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 3, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 3, 2024

Thanks for the pull request, @Ian2012!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-k8s-harmony-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Ian2012 Ian2012 marked this pull request as ready for review October 7, 2024 20:56
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Ian2012! @gabor-boros did you want to take a look?

@Ian2012
Copy link
Contributor Author

Ian2012 commented Oct 10, 2024

@bradenmacdonald I've not reviewed other helms charts because I don't have any use for them and I'm unsure how to test it. Good to know for a follow-up if anyone of you folks want to take a look.

@Ian2012 Ian2012 added the dependencies Pull requests that update a dependency file label Oct 29, 2024
@Ian2012
Copy link
Contributor Author

Ian2012 commented Nov 5, 2024

can we get this merged and released before sumac?

@bradenmacdonald
Copy link
Contributor

If we can get one more +1 from either @gabor-boros or @jfavellar90 then I think this is good to merge.

@jfavellar90
Copy link
Contributor

@gabor-boros Hi, we would like to get you involved in this conversation since we are not updating the following dependencies since we are not very familiar with testing them:

  • Velero
  • OpenFaas
  • ElasticSearch and OpenSearch (I don't think it's worth it to update them since MeiliSearch is coming. Do you agree?)

Are you OK with this approach of merging this PR as it is and leaving the update of the missing dependencies for a follow-up task? Or do you prefer checking such dependencies in this PR to apply the update of all the dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

4 participants