-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(bump): upgrade helm chart global dependencies #86
base: main
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @Ian2012! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Ian2012! @gabor-boros did you want to take a look?
@bradenmacdonald I've not reviewed other helms charts because I don't have any use for them and I'm unsure how to test it. Good to know for a follow-up if anyone of you folks want to take a look. |
can we get this merged and released before sumac? |
If we can get one more +1 from either @gabor-boros or @jfavellar90 then I think this is good to merge. |
@gabor-boros Hi, we would like to get you involved in this conversation since we are not updating the following dependencies since we are not very familiar with testing them:
Are you OK with this approach of merging this PR as it is and leaving the update of the missing dependencies for a follow-up task? Or do you prefer checking such dependencies in this PR to apply the update of all the dependencies? |
Description
This PR upgrades the helm chart dependencies to the latest version.
Cert manager cannot be upgraded to v1.16 because of this bug: cert-manager/cert-manager#1829
The upgrade was already tested on a production k8s cluster by upgrading from the current version to the new one.