Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync translation tags #1455

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Oct 4, 2023

Sync translation tags job is raising an exception in many resources. Turned out that we cannot use to_dict if the resource list of tagged strings is too long and has a next_link. It's a bug in transifex or a bad use of the API

Pythonic script is bad this time 😁

  • Tested on one of the failing jobs

We cannot use (to_dict) if the resource list is too long and has a (next_link)
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 4, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@shadinaif
Copy link
Contributor Author

Please review @OmarIthawi , @brian-smith-tcril

@OmarIthawi OmarIthawi merged commit 002c2be into openedx:main Oct 4, 2023
5 checks passed
@openedx-webhooks
Copy link

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@shadinaif shadinaif deleted the shadinaif/sync-tags-bug branch October 4, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants