Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable console errors during local development #2751

Closed
1 task
viktorrusakov opened this issue Oct 27, 2023 · 0 comments · Fixed by #2812
Closed
1 task

DataTable console errors during local development #2751

viktorrusakov opened this issue Oct 27, 2023 · 0 comments · Fixed by #2812
Assignees
Labels
code health Proactive technical investment via refactorings, removals, etc. engineering Engineering maintenance Routine upkeep necessary for the health of the platform raccoon-gang

Comments

@viktorrusakov
Copy link
Contributor

viktorrusakov commented Oct 27, 2023

When opening any component page on the docs site during local development it floods console with following error messages:
image

This is caused by #2581, where props spreading was added to some of the subcomponents of DataTable (likely to be able to pass data-testid in tests to find elements with react-testing-library in tests). However, it was not considered that react-table internally passes a lot of redundant props to our components which now get spread to the DOM elements and since DataTable is used on every component page to show its Usage Insights we have console errors everywhere.

Tasks

@viktorrusakov viktorrusakov added raccoon-gang maintenance Routine upkeep necessary for the health of the platform engineering Engineering code health Proactive technical investment via refactorings, removals, etc. labels Oct 27, 2023
@viktorrusakov viktorrusakov self-assigned this Oct 27, 2023
@viktorrusakov viktorrusakov linked a pull request Oct 27, 2023 that will close this issue
10 tasks
@viktorrusakov viktorrusakov linked a pull request Nov 15, 2023 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Proactive technical investment via refactorings, removals, etc. engineering Engineering maintenance Routine upkeep necessary for the health of the platform raccoon-gang
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant