Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: remove props spreading in DataTable components #2752

Closed

Conversation

viktorrusakov
Copy link
Contributor

@viktorrusakov viktorrusakov commented Oct 27, 2023

Description

Removes redundant props spreading in DataTable subcomponents that cause a lot of console errors during development, more details in #2751

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

Thanks for the pull request, @viktorrusakov!

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Oct 27, 2023
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit 86fe1c6
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/653b5b4d7a0cae000809cdee
😎 Deploy Preview https://deploy-preview-2752--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@viktorrusakov viktorrusakov linked an issue Oct 27, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47e4379) 92.82% compared to head (86fe1c6) 92.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2752   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files         235      235           
  Lines        4237     4237           
  Branches     1029     1029           
=======================================
  Hits         3933     3933           
  Misses        300      300           
  Partials        4        4           
Files Coverage Δ
src/DataTable/ExpandRow.jsx 100.00% <100.00%> (ø)
src/DataTable/selection/ControlledSelect.jsx 100.00% <100.00%> (ø)
src/DataTable/selection/ControlledSelectHeader.jsx 100.00% <100.00%> (ø)
.../DataTable/selection/ControlledSelectionStatus.jsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openedx-webhooks
Copy link

@viktorrusakov Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants