Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: align DataTable checkboxes #2610

Merged

Conversation

khudym
Copy link
Contributor

@khudym khudym commented Sep 8, 2023

Description

Aligned DataTable checkboxes

Issue

Deploy Preview

Deploy preview 2610

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Sep 8, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @khudym!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dfade65
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/650318b25a093e0008218215
😎 Deploy Preview https://deploy-preview-2610--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.12% 🎉

Comparison is base (b39a6a4) 91.69% compared to head (dfade65) 91.81%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2610      +/-   ##
==========================================
+ Coverage   91.69%   91.81%   +0.12%     
==========================================
  Files         235      235              
  Lines        4214     4217       +3     
  Branches     1021     1020       -1     
==========================================
+ Hits         3864     3872       +8     
+ Misses        346      341       -5     
  Partials        4        4              

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorrusakov viktorrusakov linked an issue Sep 13, 2023 that may be closed by this pull request
@viktorrusakov
Copy link
Contributor

viktorrusakov commented Sep 13, 2023

@khudym @PKulkoRaccoonGang I think this solution breaks some Form components, e.g.

Form.Radio before the changes
image

Form.Radio after the changes
image

I don't think this behaviour should be changed? Unless this is also a bug, but I don't think so, maybe @adamstankiewicz can confirm.

Can we fix this issue just for DataTable without touching styles for underlying Form components?

Also, I can't reproduce the issue you're trying to fix, for me everything looks aligned already even without adding align-items: center;
image
Maybe this was already fixed somehow?

@viktorrusakov viktorrusakov merged commit 5c1fdef into openedx:master Sep 14, 2023
9 checks passed
@openedx-webhooks
Copy link

@khudym 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.1.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 22.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

DataTable filter checkboxes are slightly off center vertically
5 participants