-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: fixed rtl direction in ProgressBar #2641
[BD-46] fix: fixed rtl direction in ProgressBar #2641
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
6b25225
to
34e148b
Compare
34e148b
to
b9c2a95
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2641 +/- ##
==========================================
- Coverage 91.90% 91.83% -0.08%
==========================================
Files 235 235
Lines 4310 4224 -86
Branches 1044 1024 -20
==========================================
- Hits 3961 3879 -82
+ Misses 345 341 -4
Partials 4 4
☔ View full report in Codecov by Sentry. |
d7f2fb0
to
4753fde
Compare
4753fde
to
bf7bbc9
Compare
07afa31
to
bf9cc45
Compare
2e6e2e3
to
a49d881
Compare
a49d881
to
20c9585
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing this RTL issue 😄
@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 21.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 22.0.0-alpha.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
rtl
direction in ProgressBar componentIssue: #2594
Deploy Preview
ProgressBar component
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist