Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: fixed rtl direction in ProgressBar #2641

Merged

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Sep 21, 2023

Description

  • fixed rtl direction in ProgressBar component

Issue: #2594

Deploy Preview

ProgressBar component

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Sep 21, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 21, 2023

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 20c9585
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/651188d3caeaed0008876643
😎 Deploy Preview https://deploy-preview-2641--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08% ⚠️

Comparison is base (7ce9a83) 91.90% compared to head (20c9585) 91.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2641      +/-   ##
==========================================
- Coverage   91.90%   91.83%   -0.08%     
==========================================
  Files         235      235              
  Lines        4310     4224      -86     
  Branches     1044     1024      -20     
==========================================
- Hits         3961     3879      -82     
+ Misses        345      341       -4     
  Partials        4        4              
Files Changed Coverage Δ
src/ProgressBar/index.jsx 97.67% <100.00%> (+0.05%) ⬆️
src/ProgressBar/utils.js 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/progress-bar-rtl branch 3 times, most recently from d7f2fb0 to 4753fde Compare September 21, 2023 14:19
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review September 21, 2023 14:20
src/ProgressBar/index.jsx Outdated Show resolved Hide resolved
src/ProgressBar/index.jsx Outdated Show resolved Hide resolved
src/ProgressBar/index.jsx Outdated Show resolved Hide resolved
src/ProgressBar/index.jsx Outdated Show resolved Hide resolved
src/ProgressBar/utils.js Outdated Show resolved Hide resolved
src/ProgressBar/utils.js Show resolved Hide resolved
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/progress-bar-rtl branch 2 times, most recently from 07afa31 to bf9cc45 Compare September 22, 2023 12:38
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/progress-bar-rtl branch 5 times, most recently from 2e6e2e3 to a49d881 Compare September 25, 2023 12:56
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing this RTL issue 😄

@adamstankiewicz adamstankiewicz merged commit b67f77c into openedx:master Sep 29, 2023
10 checks passed
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@adamstankiewicz adamstankiewicz linked an issue Sep 29, 2023 that may be closed by this pull request
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 22.0.0-alpha.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ProgressBar.Annotated dir="rtl" problem
6 participants