fix: properly test untyped selectable box sets #2736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Every PR post #2581 is showing
It seems a test was added that was setting an invalid type on
SelectableBoxSet
and eating the error to make the test pass.Before #2581, there were comments explaining this and
eslint-disable
s.paragon/src/SelectableBox/tests/SelectableBoxSet.test.jsx
Lines 74 to 76 in 1d6f95e
I decided, instead of bringing back the
eslint-disable
s, toMerge Checklist
Post-merge Checklist