Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed type for design token print-page-size #3388

Open
wants to merge 2 commits into
base: release-23.x
Choose a base branch
from
+2,747 −2,728
Open

fix: Changed type for design token print-page-size #3388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c21d231
fix: fixed design tokens build
PKulkoRaccoonGang Jan 23, 2025
f99960d
refactor: updated style-dictionary version
PKulkoRaccoonGang Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/paragon-scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ const COMMANDS = {
sendTrackInfo('openedx.paragon.cli-command.used', { command, status: 'success' });
} catch (error) {
// eslint-disable-next-line no-console
console.error(chalk.red.bold('An error occurred:', error.message));
console.error(chalk.red.bold('An error occurred:', error));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
image

After
image

sendTrackInfo('openedx.paragon.cli-command.used', { command, status: 'error', errorMsg: error.message });
process.exit(1);
}
Expand Down
45 changes: 32 additions & 13 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"react-table": "^7.7.0",
"react-transition-group": "^4.4.2",
"sass": "^1.58.3",
"style-dictionary": "^4.0.1",
"style-dictionary": "^4.3.2",
"tabbable": "^5.3.3",
"uncontrollable": "^7.2.1",
"uuid": "^9.0.0"
Expand Down
1,312 changes: 656 additions & 656 deletions styles/css/core/variables.css
View file
Open in desktop

Large diffs are not rendered by default.

4,102 changes: 2,051 additions & 2,051 deletions styles/css/themes/light/variables.css
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the update, the order of the variables in the files with the CSS has changed and units of measurement for 0 have been added (in sizes where necessary)

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion styles/scss/core/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ $user-selects: all, auto, none !default;

// Printing

$print-page-size: var(--pgn-typography-print-page-size) !default;
$print-page-size: var(--pgn-print-page-size) !default;
$print-body-min-width: map-get($grid-breakpoints, "lg") !default;

// List group
Expand Down
5 changes: 5 additions & 0 deletions tokens/src/core/global/other.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,10 @@
"$type": "percentage",
"source": "$theme-color-interval",
"$value": "8%"
},
"print-page-size": {
"source": "$print-page-size",
"$value": "a3",
"$type": "text"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the previous use of the dimension type for the print-page-size design token. However, I believe this type contradicts the documented description of the dimension type provided by the DTCG.

}
}
5 changes: 0 additions & 5 deletions tokens/src/core/global/typography.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,11 +276,6 @@
"$description": "Mobile display line height."
}
}
},
"print-page-size": {
"source": "$print-page-size",
"$value": "a3",
"$type": "dimension"
}
}
}
Loading