-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEPR]: Phase out edx-configuration #51
Comments
Big usages of configuration:
Maybe we can start shaving some of these off the list. |
I've created openedx-unsupported/devstack#943 as one step towards this and assigned it to the Arbi-BOM squad. |
At the very least, we have managed to find a solution for codejail on Tutor, which was one of the blockers of this work. |
How will New Relic configuration be handled in the future, like this file: https://github.com/openedx/configuration/blob/master/playbooks/roles/edxapp/templates/newrelic.ini.j2? I ask because I want to add some settings around logging/tracing, and at this point I'm just planning on changing them here and having it used everywhere. I'm hoping 2U is the only org affected, because no one has complained about any other changes. |
@robrap There are already several services that don't use the configuration repo, but instead have their production Docker images generated by in-repo Dockerfiles. So if there are any New Relic settings that need to be set via config file that we want active across services, we'll have to make sure the config gets into those images (and probably adjust the cookiecutter to make sure new services' Dockerfiles get that by default). |
Thanks @jmbowman. That's good to know. So far, I think we just have one server-side config related to browser. I imagine that only affects server-side templates, but I'm not certain. |
Sounds good to me! |
@dianakhuang, will this repository become private after this date? We are still using it for our deployments. We also use it for building devstack images because:
|
@Agrendalath no, we are not planning on moving it private. We are merely trying to indicate that it's the 'old, not-recommended' way of doing things by taking it out of the openedx org and indicating that it is primarily designed to support edx.org. There might be more 2U-specific customization in that case, but it might be worth it to figure out what can and should be split into other scripts/resources that might be more generalizable. |
@dianakhuang: This DEPR was moved to communicated without actually including all of the TBD data.
If others are still using edx-configuration, we might not want to move edx-configuration unless we plan to drop it from the next named release? We could also document that it will be available in the edx org, but once we move it, it has a higher chance of picking up 2U specific changes (as parts of it move or are replaced), and it will likely be archived once we are done with it. |
Add a note to clarify that EDXAPP_PRIVATE_REQUIREMENTS contains edx.org specific details, which is not ideal. The plan is to ultimately retire this repo according to the DEPR: openedx/public-engineering#51
Here is a private edx.org link for jenkins-job-dsl-internal as a reminder of uses of configuration that will need to move. It is accessing requirements files and other scripts in the configuration repo. |
Add a note to clarify that EDXAPP_PRIVATE_REQUIREMENTS contains edx.org specific details, which is not ideal. The plan is to ultimately retire this repo according to the DEPR: openedx/public-engineering#51
Copying a relevant comment: #247
TL;DR: If configuration is deprecated, it would eventually be moved to a public archive in openedx-unsupported. |
Add a note to clarify that EDXAPP_PRIVATE_REQUIREMENTS contains edx.org specific details, which is not ideal. The plan is to ultimately retire this repo according to the DEPR: openedx/public-engineering#51
We'd like to know how folks are still using this. That would make it easier for us to decide whether to keep it maintained in the openedx organization vs. deprecate it and let individual providers fork & continue to use it independently. @dianakhuang or @robrap , could you note here how you still use this repository? @feanil and I will reach out to other community providers with the same question. |
@kdmccormick: We're slowly gathering data in this ticket: edx/edx-arch-experiments#540. We can update the DEPR at some point. Thanks. |
2U is still using this repository for:
|
@dianakhuang I understand that 2U no longer wants to maintain this repository for community use. Just like with Devstack, could you re-communicate this ticket, and announce a 2 week period for someone else to step up as maintainer? If we get a maintainer, then we'll keep this in the openedx org; if not, we'll archive it to openedx-unsupported. Either way, 2U is welcome to create a fork of this repo in their edx organization and make edx.org-specific changes there. |
@kdmccormick I think we would like a longer time on this before we are ready to archive it/fork it, but it was requested that we put a deprecation notice up and remove it from the Open edX releases (pre-Redwood) earlier rather than later. I am happy to remove notices/put things back into the release if that's what AXIM would like. |
@dianakhuang Gotcha, sorry for the mixed messages, let me talk to my team and make sure we're on the same page :) |
@dianakhuang Thanks for bearing with us. The process we'd like to follow, both for this and devstack, are:
For $ACCEPTANCE_DATE, 2 weeks from now is fine since we've been tossing this around for so long, but you could push it out further to the future if you aren't ready to fork it yet. |
We did this here: https://discuss.openedx.org/t/deprecation-edx-configuration/10702 and there was no resonse so we will proceed with archiving this repository. The current plan for this is to archive this after redwood is cut to give users one last release with configuration. |
openedx/public-engineering#51 has all the details. Also drop a bunch of trailing whitespace that was in this file.
I've created openedx-unsupported/configuration#7137 to further communicate the deprecation before the removal. |
This is blocked until after the Redwood Release. Once Redwood is released, this can be archived. |
We ended up doing this early, if we need it tagged for Redwood, we can go back and add redwood branches and tags. |
Proposal Date
30 November 2020
Ticket Acceptance Date
October 13, 2023
Technology Removal Date
After Redwood Cut
First Open edX Named Release Without This Functionality
Sumac
Rationale
N/A
Removal
N/A
Replacement
Tutor
Deprecation
No response
Migration
No response
Additional Info
For now a placeholder, this will eventually describe in detail how
edx-configuration
will stop being supported by edX, including:edx-configuration
will no longer be supportedNotes from Comments:
Kyle McCormick
February 11, 2022, 9:08 AM
Edited
Jeremy Bowman
February 11, 2022, 8:33 AM
Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-122
The text was updated successfully, but these errors were encountered: