feat: add release testing label to test failure reports #349
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
| @@ -8,9 +7,11 @@ on: | |||
| jobs: | |||
| add_label: | |||
| runs-on: ubuntu-latest | |||
| if: ${{ contains(github.event.issue.title, 'Test failure') && !contains(github.event.issue.labels.*.name, 'needs triage') }} | |||
| if: ${{ contains(github.event.issue.title, 'Test failure') && !contains(github.event.issue.labels.*.name, 'needs triage') && !contains(github.event.issue.labels.*.name, 'release testing') }} | |||
There was a problem hiding this comment.
If I'm reading the conditional correctly, this means that if the issue contains only one of 'needs triage' or 'release testing', it will not add the one that's missing. Is this intentional?
There was a problem hiding this comment.
Yes. But I can rewrite so it adds the missing label. Also, I updated the test failure issue template so it includes both labels by default: dc1e84a. So now when opening an issue it'd be included as part of the default labels:
There was a problem hiding this comment.
I'm all for simplication, so my instinct is to say we should remove it... but, on the other hand, whoever added it in the first place presumably ran into a situation that made it desirable. 🤷🏼♂️
If we're keeping it, though, I think it would be a good idea to add the missing label if only one is present.
There was a problem hiding this comment.
Do we still need the job if we're using that as default? I'm guessing we do for people without enough permissions to add labels? I'm not familiar with the report view for people without any permissions.
There was a problem hiding this comment.
Yes, I think we need it. Here's the discussion we had back then: #281 (comment)
There was a problem hiding this comment.
Done: 50f9573. Thanks for the feedback, @arbrandes!
|
@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds the
release testinglabel for all testing failure reports for better trackability in the GH board.