OPENEUROPA-2659: Entity browser - improve visual styling. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanoleguskiza
suggested changes
Apr 7, 2020
tests/Behat/MediaContext.php
Outdated
| @@ -264,12 +268,14 @@ protected function getConfigContext(): ConfigContext { | |||
| * | |||
| * @param string $file_name | |||
| * File name, relative to Mink 'files_path' location. | |||
There was a problem hiding this comment.
The file name is no longer relative to the files_path (Ignore this if you take my previous comment into account)
tests/Behat/MediaContext.php
Outdated
| @@ -119,7 +119,9 @@ public function createMediaDocuments(TableNode $table): void { | |||
| // Retrieve the url table from the test scenario. | |||
| $files = $table->getColumnsHash(); | |||
| foreach ($files as $properties) { | |||
| $file = $this->createFileEntity($properties['file']); | |||
| $file_name = basename($properties['file']); | |||
There was a problem hiding this comment.
We could handle this inside the createFileEntity method to avoid duplicating the code.
imanoleguskiza
previously approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is from the Event integration, but I need this solution for testing in EWCMS since there the files are not directly in fixtures, but in separate subfolders.