Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reduce maximum page size for read auth models #122

Closed
wants to merge 1 commit into from
Closed

chore: reduce maximum page size for read auth models #122

wants to merge 1 commit into from

Conversation

adriantam
Copy link
Member

Description

Limit size to reduce load on database

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@adriantam
chore: reduce maximum page size for read auth models
e75d84e 
Limit size to reduce load on database
@adriantam adriantam requested a review from a team as a code owner December 6, 2023 23:22
rhamzeh
rhamzeh approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we go for 25 here as you suggested or 20 even?

@adriantam
Copy link
Member Author

Don't change the limit for now as it is breaking

@adriantam adriantam closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriantam @rhamzeh