Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate condition in type restriction #124

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

jpadilla
Copy link
Member

@jpadilla jpadilla commented Dec 8, 2023

Description

Add missing validation to RelationReference.condition.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jpadilla jpadilla requested a review from a team as a code owner December 8, 2023 21:15
rhamzeh
rhamzeh previously approved these changes Dec 8, 2023
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think you need the ignore empty

@jon-whit jon-whit merged commit 766fd25 into main Dec 8, 2023
3 checks passed
@jon-whit jon-whit deleted the tweak-condition branch December 8, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants