Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context to assertions #194

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Sep 4, 2024

Description

References

part of: openfga/openfga#1353

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@rhamzeh rhamzeh merged commit a45dbd0 into main Sep 4, 2024
6 checks passed
@rhamzeh rhamzeh deleted the feat/add-context-to-assertions branch September 4, 2024 17:05

// Additional request context that will be used to evaluate any ABAC conditions encountered
// in the query evaluation.
google.protobuf.Struct context = 6;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 6 and not 4??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a typo, will fix in a followup PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants