Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make CheckError types snake case #213

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

justincoh
Copy link
Contributor

@justincoh justincoh commented Dec 12, 2024

Description

These fields are being returned camel case, against the pattern of all other fields in our API responses. This PR changes them to be snake_case for consistency.

⚠️ This is a breaking change, but this feature is very new and this is unlikely to impact anyone (doesn't even exist in SDKs yet)

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@justincoh justincoh requested review from a team as code owners December 12, 2024 15:05
@justincoh justincoh merged commit 0bb89b7 into main Dec 13, 2024
5 of 6 checks passed
@justincoh justincoh deleted the fix/batch-proto-error-snake-case branch December 13, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants