Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable jacoco code coverage #14

Merged
merged 1 commit into from
May 15, 2024
Merged

chore: Enable jacoco code coverage #14

merged 1 commit into from
May 15, 2024

Conversation

d-jeffery
Copy link
Collaborator

@d-jeffery d-jeffery commented May 13, 2024

Description

  • jacoco code coverage enabled
  • tests now run on check, and are executed prior to buildPlugin
  • enable testing for all valid IDEs in github workflow

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery force-pushed the chore/code-coverage branch 3 times, most recently from 34dc6f1 to 2604fb6 Compare May 13, 2024 21:24
@d-jeffery d-jeffery requested a review from rhamzeh May 13, 2024 21:37
@d-jeffery d-jeffery marked this pull request as ready for review May 13, 2024 21:38
@d-jeffery d-jeffery requested a review from a team as a code owner May 13, 2024 21:38
@d-jeffery d-jeffery mentioned this pull request May 13, 2024
19 tasks
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't support for webstorm, rider and rubymine?

@d-jeffery
Copy link
Collaborator Author

d-jeffery commented May 14, 2024

I dont think these are necessary, but I updated verification list with versions that were available from the release repository.

As far as I can tell, this verification is meant to be used if you're dependent on IDE specific functionality of a particular version, and whether newer versions will be supported;
https://plugins.jetbrains.com/docs/intellij/verifying-plugin-compatibility.html#plugin-verifier


Edit:

Following up looking through https://www.jetbrains.com/intellij-repository/releases

Rider is a supported IDE, and is already in the list I added.

As far as I can tell, based on searching for similar checks on github and looking into the jetbrains product comparisons:

Webstorm and RubyMine provide a subset of functionality offered by Intellij IDEA Ultimate when its combined with the relevant language plugins, so assumption is here if it works on Ultimate & Community versions, it'll work on those that use the IDEA engine.


There isn't support for webstorm, rider and rubymine?

I added them from the list here:
https://github.com/marketplace/actions/intellij-platform-plugin-verifier#some-ide-options

It does say "some" not "all", will do some more digging to see if there are other ides im missing support for

@d-jeffery d-jeffery requested a review from rhamzeh May 14, 2024 19:33
@d-jeffery d-jeffery force-pushed the chore/code-coverage branch from 2604fb6 to 3fb9689 Compare May 14, 2024 20:47
@d-jeffery d-jeffery merged commit fb531fc into main May 15, 2024
14 checks passed
@d-jeffery d-jeffery deleted the chore/code-coverage branch May 15, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants