Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: external annotator for OpenFGA files #16

Merged
merged 2 commits into from
May 31, 2024
Merged

feat: external annotator for OpenFGA files #16

merged 2 commits into from
May 31, 2024

Conversation

d-jeffery
Copy link
Collaborator

@d-jeffery d-jeffery commented May 20, 2024 •
edited
Loading

Description

openfgaintellijplugin-0.1.1.zip

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery force-pushed the feat/model-validation branch 3 times, most recently from 2c13d0e to ab7a709 Compare May 22, 2024 00:27
d-jeffery
d-jeffery commented May 22, 2024
View reviewed changes
build.gradle.kts Outdated Show resolved Hide resolved
@d-jeffery d-jeffery force-pushed the feat/model-validation branch from ab7a709 to a0f9432 Compare May 22, 2024 21:40
@rhamzeh
Copy link
Member

rhamzeh commented May 31, 2024

What do we need to provide so that this value is filled?
Screenshot 2024-05-31 at 8 16 02 AM

@d-jeffery
Copy link
Collaborator Author

What do we need to provide so that this value is filled?

https://plugins.jetbrains.com/docs/intellij/plugin-configuration-file.html#idea-plugin__change-notes

Will update.

@d-jeffery d-jeffery force-pushed the feat/model-validation branch 2 times, most recently from 1a64569 to dfc3e36 Compare May 31, 2024 16:34
@d-jeffery d-jeffery marked this pull request as ready for review May 31, 2024 16:34
@d-jeffery d-jeffery requested a review from a team as a code owner May 31, 2024 16:34
@d-jeffery d-jeffery requested a review from rhamzeh May 31, 2024 16:44
rhamzeh
rhamzeh reviewed May 31, 2024
View reviewed changes
build.gradle.kts Outdated Show resolved Hide resolved
@d-jeffery d-jeffery force-pushed the feat/model-validation branch from dfc3e36 to 46428a1 Compare May 31, 2024 17:48
@d-jeffery d-jeffery requested a review from rhamzeh May 31, 2024 17:49
@d-jeffery d-jeffery merged commit 516ee35 into main May 31, 2024
4 of 5 checks passed
@d-jeffery d-jeffery deleted the feat/model-validation branch May 31, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation for model files
2 participants
@d-jeffery @rhamzeh