chore: add PathExists to graph #410
Open
+538
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miparnisari
force-pushed
the
path-exists
branch
from
e48d26b to
8b182b4
Compare
miparnisari
force-pushed
the
path-exists
branch
from
8b182b4 to
8872863
Compare
miparnisari
commented
Jan 20, 2025
| @@ -101,6 +101,23 @@ func (g *AuthorizationModelGraph) Reversed() (*AuthorizationModelGraph, error) { | |||
| return nil, fmt.Errorf("%w: could not cast to directed graph", ErrBuildingGraph) | |||
| } | |||
|
|
|||
| // PathExists returns true if both nodes exist and there is a path starting at 'fromLabel' extending to 'toLabel'. | |||
| // If both labels are equal, it returns true. | |||
There was a problem hiding this comment.
This behavior is weird to me, but it's expected. gonum/gonum#2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to have
openfga/opengaeliminate its dependency togonum. (https://github.com/openfga/openfga/blob/6d2f0703ae89caa4c94dd7678df73590edc9bfe8/go.mod#L50)Therefore, I am moving most of this code and its tests https://github.com/openfga/openfga/blob/6d2f0703ae89caa4c94dd7678df73590edc9bfe8/pkg/typesystem/typesystem.go#L737 to this repository.
References
openfga/openfga#2104