Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Makefile to build plugins #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jamar-criteo
Copy link
Collaborator

Description

Add a makefile that with the following commands:

$ make help
build                          Build the OpenFGA plugins. Build directory can be overridden using BUILD_DIR="desired/path", default is ".dist/". Usage `BUILD_DIR="." make build`
clean                          Clean project files
deps                           Download dependencies
help                           Show this help
lint                           Lint Go source files
test                           Run all tests. To run a specific test, pass the FILTER var. Usage `make test FILTER="TestCheckLogs"`

Most of the code had been ported from openfga/openfga, some might not be relevant (a review is required).

Disclaimer:

  • The Linter will be configured in another change
  • The tests don't pass yet, since most plugins are not fully implemented

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jarias-lfx
Copy link

/easycla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants