Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct link to conditions page #612

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Correct link to conditions page #612

merged 1 commit into from
Jan 2, 2024

Conversation

ewanharris
Copy link
Member

Description

Corrects the link to the Conditions page

References

Closes #593

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested a review from a team as a code owner January 2, 2024 14:32
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 2, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ewanharris / name: Ewan Harris (aa8f0e0)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

PR Preview Action v1.4.6
🚀 Deployed preview to https://openfga.github.io/openfga.dev/pr-preview/pr-612/
on branch gh-pages at 2024-01-02 14:34 UTC

poovamraj
poovamraj approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@poovamraj poovamraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rhamzeh
Copy link
Member

rhamzeh commented Jan 2, 2024

Thanks @ewanharris!

@rhamzeh rhamzeh merged commit b2308f8 into main Jan 2, 2024
11 checks passed
@rhamzeh rhamzeh deleted the fix/conditions-link branch January 2, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

@poovamraj poovamraj poovamraj approved these changes

@sergiught sergiught sergiught approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to Condition page is wrong in https://openfga.dev/docs/modeling
4 participants
@ewanharris @rhamzeh @poovamraj @sergiught