Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: REST client should not close after stream request #172

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

evansims
Copy link
Member

@evansims evansims commented Feb 14, 2025

Description

This is a minor bug fix to the new stream method added to the Python SDK's REST client in 0.9.1: the pool shouldn't close after the request concludes, as the same pool can continue to be used for future requests.

References

Generated from openfga/sdk-generator#491

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@evansims evansims added the bug Something isn't working label Feb 14, 2025
@evansims evansims force-pushed the fix/rest-client-should-not-close-after-stream branch from d5418e9 to 2a34ca4 Compare February 14, 2025 19:13
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (2db7d04) to head (d0f0ac0).

❌ Your project status has failed because the head coverage (70.37%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   70.38%   70.37%   -0.01%     
==========================================
  Files         134      134              
  Lines       10794    10792       -2     
==========================================
- Hits         7597     7595       -2     
  Misses       3197     3197              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evansims evansims force-pushed the fix/rest-client-should-not-close-after-stream branch from 2a34ca4 to d0f0ac0 Compare February 14, 2025 19:16
@evansims evansims marked this pull request as ready for review February 14, 2025 19:17
@evansims evansims requested a review from a team as a code owner February 14, 2025 19:17
@evansims evansims enabled auto-merge February 14, 2025 19:19
@evansims evansims added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit fab0f57 Feb 14, 2025
17 checks passed
@evansims evansims deleted the fix/rest-client-should-not-close-after-stream branch February 14, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants